eyecatchu/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-12 13:53:11 +09:00
Code Issues Packages Projects Releases Wiki Activity
git/builtin
History
Johannes Schindelin 321854ac46 clone.c: avoid "exceeds maximum object size" error with GCC v12.x 
Technically, the pointer difference `end - start` _could_ be negative,
and when cast to an (unsigned) `size_t` that would cause problems. In
this instance, the symptom is:

dir.c: In function 'git_url_basename':
dir.c:3087:13: error: 'memchr' specified bound [9223372036854775808, 0]
       exceeds maximum object size 9223372036854775807
       [-Werror=stringop-overread]
    CC ewah/bitmap.o
 3087 |         if (memchr(start, '/', end - start) == NULL
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

While it is a bit far-fetched to think that `end` (which is defined as
`repo + strlen(repo)`) and `start` (which starts at `repo` and never
steps beyond the NUL terminator) could result in such a negative
difference, GCC has no way of knowing that.

See also https://gcc.gnu.org/bugzilla//show_bug.cgi?id=85783.

Let's just add a safety check, primarily for GCC's benefit.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2023-03-22 17:53:32 +01:00
..
add.c
drop unused argc parameters
2020-09-30 12:53:47 -07:00
am.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
annotate.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
apply.c
apply.c: make init_apply_state() take a struct repository
2018-08-13 14:14:44 -07:00
archive.c
pack-protocol.txt: accept error packets in any context
2019-01-02 13:05:30 -08:00
bisect--helper.c
Merge branch 'mr/bisect-in-c-3'
2020-11-09 14:06:25 -08:00
blame.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
branch.c
branch: sort detached HEAD based on a flag
2021-01-07 15:13:21 -08:00
bugreport.c
builtin/bugreport.c: use thread-safe localtime_r()
2020-12-01 13:05:37 -08:00
bundle.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
cat-file.c
Merge branch 'cc/cat-file-usage-update' into master
2020-07-09 14:00:41 -07:00
check-attr.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
check-ignore.c
dir: fix problematic API to avoid memory leaks
2020-08-18 17:17:31 -07:00
check-mailmap.c
config: don't include config.h by default
2017-06-15 12:56:22 -07:00
check-ref-format.c
Merge branch 'jc/check-ref-format-oor' into maint
2017-11-15 12:04:57 +09:00
checkout-index.c
checkout-index: propagate errors to exit code
2020-10-27 12:41:56 -07:00
checkout.c
Merge branch 'dl/checkout-p-merge-base'
2020-12-23 13:59:46 -08:00
clean.c
quote_path: give flags parameter to quote_path()
2020-09-10 10:49:19 -07:00
clone.c
clone.c: avoid "exceeds maximum object size" error with GCC v12.x
2023-03-22 17:53:32 +01:00
column.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
commit-graph.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
commit-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
commit.c
Documentation: stylistically normalize references to Signed-off-by:
2020-10-20 11:57:40 -07:00
config.c
config: implement --fixed-value with --get*
2020-11-25 14:43:48 -08:00
count-objects.c
rename "alternate_object_database" to "object_directory"
2018-11-13 14:22:02 +09:00
credential-cache--daemon.c
make credential helpers builtins
2020-08-13 11:02:08 -07:00
credential-cache.c
Merge branch 'jc/undash-in-tree-git-callers'
2020-09-03 12:37:03 -07:00
credential-store.c
crendential-store: use timeout when locking file
2020-11-25 12:30:18 -08:00
credential.c
credential: load default config
2020-10-16 12:30:45 -07:00
describe.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
diff-files.c
diff-files: treat "i-t-a" files as "not-in-index"
2020-06-22 10:46:45 -07:00
diff-index.c
builtin/diff-index: learn --merge-base
2020-09-20 21:30:26 -07:00
diff-tree.c
builtin/diff-tree: learn --merge-base
2020-09-21 13:37:03 -07:00
diff.c
Merge branch 'dl/diff-merge-base'
2020-11-02 13:17:39 -08:00
difftool.c
Use new HASHMAP_INIT macro to simplify hashmap initialization
2020-11-11 12:55:27 -08:00
env--helper.c
assert PARSE_OPT_NONEG in parse-options callbacks
2020-09-30 12:53:47 -07:00
fast-export.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
fast-import.c
Merge branch 'jk/fast-import-marks-cleanup'
2020-11-02 13:17:40 -08:00
fetch-pack.c
fetch-pack: remove no_dependents code
2020-08-18 16:46:53 -07:00
fetch.c
hashmap: provide deallocation function names
2020-11-02 12:15:50 -08:00
fmt-merge-msg.c
Lib-ify fmt-merge-msg
2020-03-24 15:04:43 -07:00
for-each-ref.c
ref-filter: move ref_sorting flags to a bitfield
2021-01-07 15:13:21 -08:00
for-each-repo.c
for-each-repo: do nothing on empty config
2021-01-07 19:12:02 -08:00
fsck.c
fsck: do not lazy fetch known non-promisor object
2020-08-06 13:01:03 -07:00
gc.c
builtin/gc: don't peek into struct lock_file
2021-01-06 13:53:32 -08:00
get-tar-commit-id.c
builtin/get-tar-commit-id: make hash size independent
2019-04-01 11:57:39 +09:00
grep.c
grep: use designated initializers for grep_defaults
2020-11-21 14:50:33 -08:00
hash-object.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
help.c
help: drop usage of 'common' and 'useful' for guides
2020-08-04 18:34:01 -07:00
index-pack.c
compute pack .idx byte offsets using size_t
2020-11-16 13:41:35 -08:00
init-db.c
get_default_branch_name(): prepare for showing some advice
2020-12-13 15:53:50 -08:00
interpret-trailers.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
log.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
ls-files.c
dir: fix problematic API to avoid memory leaks
2020-08-18 17:17:31 -07:00
ls-remote.c
Merge branch 'jk/unleak-fixes'
2020-08-24 14:54:30 -07:00
ls-tree.c
Merge branch 'nd/attr-pathspec-in-tree-walk'
2019-01-14 15:29:28 -08:00
mailinfo.c
prefix_filename: return newly allocated string
2017-03-21 11:18:41 -07:00
mailsplit.c
mailinfo & mailsplit: check for EOF while parsing
2017-05-08 12:18:19 +09:00
merge-base.c
rebase: --fork-point regression fix
2020-02-11 09:59:39 -08:00
merge-file.c
assert NOARG/NONEG behavior of parse-options callbacks
2018-11-06 12:56:29 +09:00
merge-index.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
merge-ours.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
merge-recursive.c
Ensure index matches head before invoking merge machinery, round N
2019-08-19 10:08:03 -07:00
merge-tree.c
merge-base, xdiff: zero out xpparam_t structures
2020-10-20 12:53:26 -07:00
merge.c
Merge branch 'en/merge-ort-api-null-impl'
2020-11-18 13:32:53 -08:00
mktag.c
sha1-file: allow check_object_signature() to handle any repo
2020-01-31 10:45:39 -08:00
mktree.c
mktree: drop unused length parameter
2019-05-13 14:22:54 +09:00
multi-pack-index.c
multi-pack-index: add [--[no-]progress] option.
2019-10-23 12:05:06 +09:00
mv.c
git-mv: improve error message for conflicted file
2020-07-20 14:35:43 -07:00
name-rev.c
messages: avoid SHA-1 in end-user facing messages
2020-08-14 09:33:37 -07:00
notes.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
pack-objects.c
Merge branch 'jc/object-names-are-not-sha-1'
2020-08-19 16:14:52 -07:00
pack-redundant.c
Merge branch 'jx/pack-redundant-on-single-pack'
2020-12-23 13:59:46 -08:00
pack-refs.c
Honor core.precomposeUnicode in more places
2019-04-26 10:54:03 +09:00
patch-id.c
patch-id: use oid_to_hex() to print multiple object IDs
2019-12-09 12:26:40 -08:00
prune-packed.c
Lib-ify prune-packed
2020-03-24 15:04:44 -07:00
prune.c
Merge branch 'tb/shallow-cleanup'
2020-05-13 12:19:18 -07:00
pull.c
Merge branch 'pb/pull-rebase-recurse-submodules'
2020-12-03 00:18:06 -08:00
push.c
Merge branch 'sk/force-if-includes'
2020-10-27 15:09:49 -07:00
range-diff.c
strvec: convert builtin/ callers away from argv_array name
2020-07-28 15:02:18 -07:00
read-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
rebase.c
Merge branch 'rs/rebase-commit-validation' into maint
2021-02-05 16:31:22 -08:00
receive-pack.c
Merge branch 'js/trace2-session-id'
2020-12-08 15:11:20 -08:00
reflog.c
Merge branch 'es/get-worktrees-unsort'
2020-07-06 22:09:15 -07:00
remote-ext.c
strvec: convert builtin/ callers away from argv_array name
2020-07-28 15:02:18 -07:00
remote-fd.c
remote-{ext,fd}: print usage message on invalid arguments
2017-05-30 14:45:04 +09:00
remote.c
config: convert multi_replace to flags
2020-11-25 14:43:47 -08:00
repack.c
builtin/repack.c: don't move existing packs out of the way
2020-11-17 13:31:55 -08:00
replace.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
rerere.c
Merge branch 'nd/the-index' into md/list-objects-filter-by-depth
2019-01-15 15:38:29 -08:00
reset.c
wt-status: tolerate dangling marks
2020-09-02 14:39:25 -07:00
rev-list.c
bisect: combine args passed to find_bisection()
2020-08-07 15:13:03 -07:00
rev-parse.c
rev-parse: handle --end-of-options
2020-11-10 13:46:27 -08:00
revert.c
Merge branch 'en/merge-ort-api-null-impl'
2020-11-18 13:32:53 -08:00
rm.c
rm: support the --pathspec-from-file option
2020-02-19 10:56:49 -08:00
send-pack.c
push: parse and set flag for "--force-if-includes"
2020-10-03 09:59:19 -07:00
shortlog.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
show-branch.c
Merge branch 'jt/interpret-branch-name-fallback'
2020-09-09 13:53:09 -07:00
show-index.c
builtin/show-index: provide options to determine hash algo
2020-05-27 10:07:07 -07:00
show-ref.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
sparse-checkout.c
sparse-checkout: fill in some options boilerplate
2020-09-30 12:53:48 -07:00
stash.c
Merge branch 'en/stash-apply-sparse-checkout' into maint
2021-02-05 16:31:22 -08:00
stripspace.c
stripspace: allow -s/-c outside git repository
2018-12-26 15:41:47 -08:00
submodule--helper.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
symbolic-ref.c
refs: rename constant REF_NODEREF to REF_NO_DEREF
2017-11-06 10:31:08 +09:00
tag.c
ref-filter: move ref_sorting flags to a bitfield
2021-01-07 15:13:21 -08:00
unpack-file.c
object-store: move object access functions to object-store.h
2018-05-16 11:42:03 +09:00
unpack-objects.c
sha1-file: pass git_hash_algo to hash_object_file()
2020-01-31 10:45:39 -08:00
update-index.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
update-ref.c
update-ref: disallow "start" for ongoing transactions
2020-11-16 13:44:01 -08:00
update-server-info.c
parse-options: let OPT__FORCE take optional flags argument
2018-02-09 10:24:50 -08:00
upload-archive.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
upload-pack.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
var.c
config: don't include config.h by default
2017-06-15 12:56:22 -07:00
verify-commit.c
Merge branch 'jk/no-system-includes-in-dot-c'
2019-07-31 14:38:56 -07:00
verify-pack.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
verify-tag.c
verify-tag: drop signal.h include
2019-06-19 08:19:21 -07:00
worktree.c
Merge branch 'mt/worktree-error-message-fix'
2020-11-30 14:49:43 -08:00
write-tree.c
cmd_{read,write}_tree: rename "unused" variable that is used
2019-05-13 14:22:53 +09:00