Patrick Steinhardt eb22e7dfa2 attr: fix overflow when upserting attribute with overly long name
The function `git_attr_internal()` is called to upsert attributes into
the global map. And while all callers pass a `size_t`, the function
itself accepts an `int` as the attribute name's length. This can lead to
an integer overflow in case the attribute name is longer than `INT_MAX`.

Now this overflow seems harmless as the first thing we do is to call
`attr_name_valid()`, and that function only succeeds in case all chars
in the range of `namelen` match a certain small set of chars. We thus
can't do an out-of-bounds read as NUL is not part of that set and all
strings passed to this function are NUL-terminated. And furthermore, we
wouldn't ever read past the current attribute name anyway due to the
same reason. And if validation fails we will return early.

On the other hand it feels fragile to rely on this behaviour, even more
so given that we pass `namelen` to `FLEX_ALLOC_MEM()`. So let's instead
just do the correct thing here and accept a `size_t` as line length.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-12-05 15:14:16 +09:00
2022-10-06 17:38:16 -04:00
2020-11-09 14:06:25 -08:00
2020-08-13 11:02:15 -07:00
2020-12-08 15:11:21 -08:00
2020-03-05 10:43:02 -08:00
2020-12-08 15:11:17 -08:00
2020-12-18 15:15:18 -08:00
2019-09-28 14:04:16 +09:00
2019-11-18 15:21:28 +09:00
2020-11-21 15:14:38 -08:00
2020-09-02 14:39:25 -07:00
2019-07-09 15:25:44 -07:00
2020-11-18 13:32:53 -08:00
2020-08-11 18:04:11 -07:00
2021-02-12 15:51:12 +01:00
2020-08-10 10:23:57 -07:00
2020-09-30 12:53:47 -07:00
2019-12-01 09:04:36 -08:00
2020-07-06 22:09:13 -07:00
2020-08-24 14:54:31 -07:00
2020-11-12 09:40:06 -08:00
2020-07-30 19:18:06 -07:00
2019-05-05 15:20:10 +09:00
2020-12-18 15:15:18 -08:00
2020-11-02 13:17:44 -08:00
2020-11-21 15:14:38 -08:00
2020-08-27 14:04:49 -07:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2020-09-03 12:37:04 -07:00
2020-03-24 15:04:43 -07:00
2020-08-10 10:23:57 -07:00
2020-11-09 14:06:25 -08:00
2022-10-06 17:38:16 -04:00
2020-07-30 19:18:06 -07:00
2019-11-18 15:21:28 +09:00
2020-11-30 13:55:54 -08:00
2020-07-30 19:18:06 -07:00
2020-06-25 12:27:47 -07:00
2020-12-14 15:01:03 -08:00
2019-11-18 15:21:28 +09:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2021-01-06 13:53:32 -08:00
2020-05-01 13:39:55 -07:00
2020-11-21 15:14:38 -08:00
2020-11-25 15:24:52 -08:00
2019-05-05 15:20:10 +09:00
2020-12-08 15:11:18 -08:00
2020-08-28 14:07:09 -07:00
2020-07-30 19:18:06 -07:00
2019-12-16 13:08:39 -08:00
2020-07-06 22:09:13 -07:00
2018-11-02 12:14:21 +09:00
2020-03-24 15:04:44 -07:00
2020-03-24 15:04:44 -07:00
2020-12-14 10:21:36 -08:00
2020-10-27 15:09:50 -07:00
2022-10-06 17:38:16 -04:00
2020-10-27 15:09:49 -07:00
2019-11-10 16:00:54 +09:00
2020-04-29 16:15:27 -07:00
2021-02-12 15:51:12 +01:00
2020-11-21 15:14:38 -08:00
2020-07-28 15:02:17 -07:00
2020-09-02 14:39:25 -07:00
2019-11-13 10:09:10 +09:00
2019-11-18 15:21:29 +09:00
2020-07-30 19:18:06 -07:00
2020-07-30 19:18:06 -07:00
2021-02-12 15:49:35 +01:00
2019-09-05 14:10:18 -07:00
2020-07-30 19:18:06 -07:00
2021-02-12 15:50:14 +01:00
2020-07-28 15:02:17 -07:00
2019-11-10 16:00:54 +09:00
2020-11-02 13:17:46 -08:00
2020-10-05 14:01:52 -07:00
2020-10-05 14:01:52 -07:00
2018-10-19 13:34:02 +09:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 582 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%