Jeff King e30d463d45 reflog-walk: include all fields when freeing complete_reflogs
When we encounter an error adding reflogs for a walk, we try
to free any logs we have read. But we didn't free all
fields, meaning that we could in theory leak all of the
"items" array (which would consitute the bulk of the
allocated memory).

This patch adds a helper which frees all of the entries and
uses it as appropriate.

As it turns out, the leak seems impossible to trigger with
the current code. Of the three error paths that free the
complete_reflogs struct, two only kick in when the items
array is empty, and the third was removed entirely in the
previous commit.

So this patch should be a noop in terms of behavior, but it
fixes a potential maintenance headache should anybody add a
new error path and copy the partial-free code. Which is
what happened in 5026b47175 (add_reflog_for_walk: avoid
memory leak, 2017-05-04), though its leaky call was the
third one that was recently removed.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-07-07 09:04:34 -07:00
2017-06-24 15:31:36 -07:00
2017-05-10 13:32:50 +09:00
2017-04-26 15:39:13 +09:00
2017-06-07 09:25:20 +09:00
2017-03-24 13:31:01 -07:00
2016-02-22 14:51:09 -08:00
2016-11-22 13:55:20 -08:00
2016-02-22 14:50:32 -08:00
2016-02-22 14:50:32 -08:00
2017-03-13 15:28:54 -07:00
2017-03-13 15:28:54 -07:00
2016-05-09 12:29:08 -07:00
2016-02-22 14:51:09 -08:00
2017-04-19 21:37:13 -07:00
2017-01-25 14:42:37 -08:00
2016-08-12 09:47:37 -07:00
2017-03-31 08:33:56 -07:00
2016-05-09 12:29:08 -07:00
2014-12-12 14:31:42 -08:00
2016-07-27 14:15:51 -07:00
2015-11-20 08:02:05 -05:00
2017-05-01 11:01:52 +09:00
2017-03-31 08:33:56 -07:00
2016-09-29 15:42:18 -07:00
2016-05-09 12:29:08 -07:00
2017-03-31 08:33:56 -07:00
2017-03-31 08:33:56 -07:00
2017-03-31 08:33:56 -07:00
2016-07-01 12:44:57 -07:00
2016-07-01 12:44:57 -07:00
2017-04-26 15:39:02 +09:00
2017-06-24 15:31:36 -07:00
2017-02-15 12:54:19 -08:00
2017-03-17 10:40:25 -07:00
2017-03-22 13:41:41 -07:00
2017-03-22 13:41:41 -07:00
2016-02-22 14:51:09 -08:00
2017-05-08 12:18:20 +09:00
2017-01-30 14:17:00 -08:00
2016-12-07 11:31:59 -08:00
2017-05-22 10:20:46 +09:00
2016-12-07 11:31:59 -08:00
2016-07-29 11:05:07 -07:00
2016-07-29 11:05:07 -07:00
2017-03-31 20:57:18 -07:00
2017-01-30 14:17:00 -08:00
2017-02-08 15:39:55 -08:00
2017-02-08 15:39:55 -08:00
2017-01-30 14:17:00 -08:00
2017-03-28 14:05:59 -07:00
2017-03-10 13:24:24 -08:00
2016-07-28 11:26:03 -07:00
2016-07-28 11:26:03 -07:00
2017-04-19 21:37:13 -07:00
2017-04-26 15:39:13 +09:00
2017-06-13 13:30:16 -07:00
2016-04-25 15:17:15 -07:00
2017-04-19 21:37:13 -07:00
2017-03-31 08:33:56 -07:00
2017-03-31 08:33:56 -07:00
2017-03-31 08:33:56 -07:00
2017-05-22 10:20:46 +09:00
2017-05-22 10:20:46 +09:00
2017-05-08 12:18:20 +09:00
2016-08-05 09:28:17 -07:00
2016-09-29 15:42:18 -07:00
2016-02-22 10:40:35 -08:00
2016-09-26 18:16:23 -07:00

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 582 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%