Kevin Willford dd0b61f577 fsmonitor: fix watchman integration
When running Git commands quickly -- such as in a shell script or the
test suite -- the Git commands frequently complete and start again
during the same second. The example fsmonitor hooks to integrate with
Watchman truncate the nanosecond times to seconds. In principle, this is
fine, as Watchman claims to use inclusive comparisons [1]. The result
should only be an over-representation of the changed paths since the
last Git command.

However, Watchman's own documentation claims "Using a timestamp is prone
to race conditions in understanding the complete state of the file tree"
[2]. All of their documented examples use a "clockspec" that looks like
'c:123:234'. Git should eventually learn how to store this type of
string to provide a stronger integration, but that will be a more
invasive change.

When using GIT_TEST_FSMONITOR="$(pwd)/t7519/fsmonitor-watchman", scripts
such as t7519-wtstatus.sh fail due to these race conditions. In fact,
running any test script with GIT_TEST_FSMONITOR pointing at
t/t7519/fsmonitor-wathcman will cause failures in the test_commit
function. The 'git add "$indir$file"' command fails due to not enough
time between the creation of '$file' and the 'git add' command.

For now, subtract one second from the timestamp we pass to Watchman.
This will make our window large enough to avoid these race conditions.
Increasing the window causes tests like t7519-wtstatus.sh to pass.

When the integration was introduced in def437671 (fsmonitor: add a
sample integration script for Watchman, 2018-09-22), the query included
an expression that would ignore files created and deleted in that
window. The performance reason for this change was to ignore temporary
files created by a build between Git commands. However, this causes
failures in script scenarios where Git is creating or deleting files
quickly.

When using GIT_TEST_FSMONITOR as before, t2203-add-intent.sh fails
due to this add-and-delete race condition.

By removing the "expression" from the Watchman query, we remove this
race condition. It will lead to some performance degradation in the case
of users creating and deleting temporary files inside their working
directory between Git commands. However, that is a cost we need to pay
to be correct.

[1] https://github.com/facebook/watchman/blob/master/query/since.cpp#L35-L39
[2] https://facebook.github.io/watchman/docs/clockspec.html

Helped-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Kevin Willford <Kevin.Willford@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-11-06 12:23:30 +09:00
2019-07-29 12:39:13 -07:00
2019-08-02 13:12:02 -07:00
2019-08-02 13:12:02 -07:00
2019-08-11 17:41:39 -07:00
2019-04-01 11:57:39 +09:00
2019-04-01 11:57:39 +09:00
2019-05-14 16:45:01 +09:00
2019-11-06 12:23:30 +09:00
2019-05-30 10:50:45 -07:00
2019-08-02 13:12:02 -07:00
2018-09-12 15:15:34 -07:00
2019-01-02 10:19:05 -08:00
2019-07-19 11:30:21 -07:00
2019-07-19 11:30:20 -07:00
2019-07-09 15:25:44 -07:00
2019-07-09 15:25:44 -07:00
2019-07-25 13:59:20 -07:00
2018-03-30 12:49:57 -07:00
2018-03-30 12:49:57 -07:00
2018-08-20 12:41:32 -07:00
2019-07-09 15:25:43 -07:00
2019-05-05 15:20:10 +09:00
2018-10-19 13:34:02 +09:00
2019-07-09 15:25:43 -07:00
2019-05-13 23:50:32 +09:00
2019-07-19 11:30:20 -07:00
2019-07-25 13:59:20 -07:00
2019-08-16 10:28:23 -07:00
2019-08-02 13:12:02 -07:00
2019-06-13 13:19:42 -07:00
2019-05-05 15:20:10 +09:00
2019-04-22 11:14:43 +09:00
2017-09-06 17:19:54 +09:00
2018-08-29 13:05:35 -07:00
2019-08-02 13:12:02 -07:00
2019-01-14 12:13:04 -08:00
2019-06-11 10:34:40 -07:00
2019-07-09 15:25:43 -07:00
2019-07-19 11:30:19 -07:00
2019-07-19 11:30:20 -07:00
2019-07-19 11:30:20 -07:00
2019-05-05 15:20:10 +09:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2019-06-17 18:15:04 -07:00
2019-02-05 14:26:09 -08:00
2018-11-02 12:14:21 +09:00
2019-07-11 15:16:49 -07:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2018-08-15 15:08:23 -07:00
2019-04-01 11:57:39 +09:00
2019-01-14 12:13:04 -08:00
2019-05-05 15:20:10 +09:00
2018-06-01 15:06:37 +09:00
2019-02-05 14:26:11 -08:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2019-05-13 23:50:35 +09:00
2019-05-05 15:20:10 +09:00
2019-06-21 11:24:08 -07:00
2018-10-19 13:34:02 +09:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 581 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%