eyecatchu/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-12 13:53:11 +09:00
Code Issues Packages Projects Releases Wiki Activity
git/builtin
History
Andrzej Hunt 68ffe095a2 transport: also free remote_refs in transport_disconnect() 
transport_get_remote_refs() can populate the transport struct's
remote_refs. transport_disconnect() is already responsible for most of
transport's cleanup - therefore we also take care of freeing remote_refs
there.

There are 2 locations where transport_disconnect() is called before
we're done using the returned remote_refs. This patch changes those
callsites to only call transport_disconnect() after the returned refs
are no longer being used - which is necessary to safely be able to
free remote_refs during transport_disconnect().

This commit fixes the following leak which was found while running
t0000, but is expected to also fix the same pattern of leak in all
locations that use transport_get_remote_refs():

Direct leak of 165 byte(s) in 1 object(s) allocated from:
    #0 0x49a6b2 in calloc /home/abuild/rpmbuild/BUILD/llvm-11.0.0.src/build/../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:154:3
    #1 0x9a72f2 in xcalloc /home/ahunt/oss-fuzz/git/wrapper.c:140:8
    #2 0x8ce203 in alloc_ref_with_prefix /home/ahunt/oss-fuzz/git/remote.c:867:20
    #3 0x8ce1a2 in alloc_ref /home/ahunt/oss-fuzz/git/remote.c:875:9
    #4 0x72f63e in process_ref_v2 /home/ahunt/oss-fuzz/git/connect.c:426:8
    #5 0x72f21a in get_remote_refs /home/ahunt/oss-fuzz/git/connect.c:525:8
    #6 0x979ab7 in handshake /home/ahunt/oss-fuzz/git/transport.c:305:4
    #7 0x97872d in get_refs_via_connect /home/ahunt/oss-fuzz/git/transport.c:339:9
    #8 0x9774b5 in transport_get_remote_refs /home/ahunt/oss-fuzz/git/transport.c:1388:4
    #9 0x51cf80 in cmd_clone /home/ahunt/oss-fuzz/git/builtin/clone.c:1271:9
    #10 0x4cd60d in run_builtin /home/ahunt/oss-fuzz/git/git.c:453:11
    #11 0x4cb2da in handle_builtin /home/ahunt/oss-fuzz/git/git.c:704:3
    #12 0x4ccc37 in run_argv /home/ahunt/oss-fuzz/git/git.c:771:4
    #13 0x4cac29 in cmd_main /home/ahunt/oss-fuzz/git/git.c:902:19
    #14 0x69c45e in main /home/ahunt/oss-fuzz/git/common-main.c:52:11
    #15 0x7f6a459d5349 in __libc_start_main (/lib64/libc.so.6+0x24349)

Signed-off-by: Andrzej Hunt <ajrhunt@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-03-21 14:39:10 -07:00
..
add.c
add: propagate --chmod errors to exit status
2021-02-24 12:14:51 -08:00
am.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
annotate.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
apply.c
…
archive.c
pack-protocol.txt: accept error packets in any context
2019-01-02 13:05:30 -08:00
bisect--helper.c
bisect--helper: retire --check-and-set-terms subcommand
2021-02-03 14:52:09 -08:00
blame.c
Merge branch 'rs/blame-optim'
2021-02-25 16:43:29 -08:00
branch.c
Merge branch 'ph/use-delete-refs'
2021-02-05 16:40:45 -08:00
bugreport.c
builtin/bugreport.c: use thread-safe localtime_r()
2020-12-01 13:05:37 -08:00
bundle.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
cat-file.c
Merge branch 'cc/cat-file-usage-update' into master
2020-07-09 14:00:41 -07:00
check-attr.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
check-ignore.c
dir: fix problematic API to avoid memory leaks
2020-08-18 17:17:31 -07:00
check-mailmap.c
shortlog: remove unused(?) "repo-abbrev" feature
2021-01-12 14:04:42 -08:00
check-ref-format.c
…
checkout-index.c
checkout-index: omit entries with no tempname from --temp output
2021-02-16 11:27:18 -08:00
checkout.c
cache-tree: clean up cache_tree_update()
2021-01-23 17:14:07 -08:00
clean.c
quote_path: give flags parameter to quote_path()
2020-09-10 10:49:19 -07:00
clone.c
clone: free or UNLEAK further pointers when finished
2021-03-14 15:57:59 -07:00
column.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
commit-graph.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
commit-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
commit.c
shortlog: remove unused(?) "repo-abbrev" feature
2021-01-12 14:04:42 -08:00
config.c
config: implement --fixed-value with --get*
2020-11-25 14:43:48 -08:00
count-objects.c
rename "alternate_object_database" to "object_directory"
2018-11-13 14:22:02 +09:00
credential-cache--daemon.c
make credential helpers builtins
2020-08-13 11:02:08 -07:00
credential-cache.c
Merge branch 'jc/undash-in-tree-git-callers'
2020-09-03 12:37:03 -07:00
credential-store.c
crendential-store: use timeout when locking file
2020-11-25 12:30:18 -08:00
credential.c
credential: load default config
2020-10-16 12:30:45 -07:00
describe.c
refs: switch peel_ref() to peel_iterated_oid()
2021-01-21 15:51:31 -08:00
diff-files.c
Merge branch 'jc/diffcore-rotate'
2021-02-25 16:43:30 -08:00
diff-index.c
Merge branch 'jc/diffcore-rotate'
2021-02-25 16:43:30 -08:00
diff-tree.c
Merge branch 'jc/diffcore-rotate'
2021-02-25 16:43:30 -08:00
diff.c
Merge branch 'jc/diffcore-rotate'
2021-02-25 16:43:30 -08:00
difftool.c
Use new HASHMAP_INIT macro to simplify hashmap initialization
2020-11-11 12:55:27 -08:00
env--helper.c
assert PARSE_OPT_NONEG in parse-options callbacks
2020-09-30 12:53:47 -07:00
fast-export.c
builtin/*: update usage format
2021-01-06 15:10:49 -08:00
fast-import.c
Merge branch 'jk/fast-import-marks-cleanup'
2020-11-02 13:17:40 -08:00
fetch-pack.c
connect, transport: encapsulate arg in struct
2021-02-05 13:49:54 -08:00
fetch.c
Merge branch 'jt/clone-unborn-head'
2021-02-17 17:21:40 -08:00
fmt-merge-msg.c
Lib-ify fmt-merge-msg
2020-03-24 15:04:43 -07:00
for-each-ref.c
ref-filter: move ref_sorting flags to a bitfield
2021-01-07 15:13:21 -08:00
for-each-repo.c
for-each-repo: do nothing on empty config
2021-01-07 19:12:02 -08:00
fsck.c
fsck: make fsck_config() re-usable
2021-01-05 14:58:29 -08:00
gc.c
maintenance: fix incorrect maintenance.repo path with bare repository
2021-02-23 00:22:45 -08:00
get-tar-commit-id.c
builtin/get-tar-commit-id: make hash size independent
2019-04-01 11:57:39 +09:00
grep.c
Merge branch 'mt/grep-sparse-checkout'
2021-02-25 16:43:31 -08:00
hash-object.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
help.c
help: drop usage of 'common' and 'useful' for guides
2020-08-04 18:34:01 -07:00
index-pack.c
Merge branch 'jt/transfer-fsck-across-packs'
2021-03-01 14:02:57 -08:00
init-db.c
init-db: silence template_dir leak when converting to absolute path
2021-03-14 15:58:00 -07:00
interpret-trailers.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
log.c
Merge branch 'ab/diff-deferred-free'
2021-02-22 16:12:43 -08:00
ls-files.c
ls-files.c: add --deduplicate option
2021-01-23 11:48:20 -08:00
ls-remote.c
transport: also free remote_refs in transport_disconnect()
2021-03-21 14:39:10 -07:00
ls-tree.c
Merge branch 'nd/attr-pathspec-in-tree-walk'
2019-01-14 15:29:28 -08:00
mailinfo.c
…
mailsplit.c
…
merge-base.c
rebase: --fork-point regression fix
2020-02-11 09:59:39 -08:00
merge-file.c
assert NOARG/NONEG behavior of parse-options callbacks
2018-11-06 12:56:29 +09:00
merge-index.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
merge-ours.c
cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
2019-01-24 11:55:06 -08:00
merge-recursive.c
Ensure index matches head before invoking merge machinery, round N
2019-08-19 10:08:03 -07:00
merge-tree.c
merge-base, xdiff: zero out xpparam_t structures
2020-10-20 12:53:26 -07:00
merge.c
Merge branch 'so/log-diff-merge'
2021-02-05 16:40:44 -08:00
mktag.c
mktag: add a --[no-]strict option
2021-01-06 14:22:24 -08:00
mktree.c
mktree: drop unused length parameter
2019-05-13 14:22:54 +09:00
multi-pack-index.c
multi-pack-index: add [--[no-]progress] option.
2019-10-23 12:05:06 +09:00
mv.c
git-mv: improve error message for conflicted file
2020-07-20 14:35:43 -07:00
name-rev.c
oid_pos(): access table through const pointers
2021-01-28 12:03:26 -08:00
notes.c
replace "parameters" by "arguments" in error messages
2021-02-23 13:30:45 -08:00
pack-objects.c
Merge branch 'tb/pack-revindex-on-disk'
2021-02-12 14:21:04 -08:00
pack-redundant.c
Merge branch 'jc/deprecate-pack-redundant'
2021-01-25 14:19:18 -08:00
pack-refs.c
Honor core.precomposeUnicode in more places
2019-04-26 10:54:03 +09:00
patch-id.c
patch-id: use oid_to_hex() to print multiple object IDs
2019-12-09 12:26:40 -08:00
prune-packed.c
Lib-ify prune-packed
2020-03-24 15:04:44 -07:00
prune.c
Merge branch 'tb/shallow-cleanup'
2020-05-13 12:19:18 -07:00
pull.c
pull: display default warning only when non-ff
2020-12-15 17:39:42 -08:00
push.c
Merge branch 'jc/push-delete-nothing'
2021-02-25 16:43:33 -08:00
range-diff.c
Merge branch 'js/range-diff-one-side-only'
2021-02-17 17:21:41 -08:00
read-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
rebase.c
rebase: add a config option for --no-fork-point
2021-02-24 11:49:10 -08:00
receive-pack.c
Merge branch 'jt/transfer-fsck-across-packs'
2021-03-01 14:02:57 -08:00
reflog.c
reflog expire --stale-fix: be generous about missing objects
2021-02-11 09:21:52 -08:00
remote-ext.c
strvec: convert builtin/ callers away from argv_array name
2020-07-28 15:02:18 -07:00
remote-fd.c
…
remote.c
transport: also free remote_refs in transport_disconnect()
2021-03-21 14:39:10 -07:00
repack.c
packfile: prepare for the existence of '*.rev' files
2021-01-25 18:32:43 -08:00
replace.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
rerere.c
Merge branch 'nd/the-index' into md/list-objects-filter-by-depth
2019-01-15 15:38:29 -08:00
reset.c
reset: free instead of leaking unneeded ref
2021-03-14 15:57:59 -07:00
rev-list.c
rev-list: add --disk-usage option for calculating disk usage
2021-02-11 09:57:55 -08:00
rev-parse.c
rev-parse: add option for absolute or relative path formatting
2020-12-12 23:35:51 -08:00
revert.c
Merge branch 'en/merge-ort-api-null-impl'
2020-11-18 13:32:53 -08:00
rm.c
rm: support the --pathspec-from-file option
2020-02-19 10:56:49 -08:00
send-pack.c
push: parse and set flag for "--force-if-includes"
2020-10-03 09:59:19 -07:00
shortlog.c
Merge branch 'ab/mailmap'
2021-01-25 14:19:19 -08:00
show-branch.c
Merge branch 'jt/interpret-branch-name-fallback'
2020-09-09 13:53:09 -07:00
show-index.c
builtin/show-index: provide options to determine hash algo
2020-05-27 10:07:07 -07:00
show-ref.c
refs: switch peel_ref() to peel_iterated_oid()
2021-01-21 15:51:31 -08:00
sparse-checkout.c
sparse-checkout: load sparse-checkout patterns
2021-01-23 17:14:07 -08:00
stash.c
Merge branch 'js/params-vs-args'
2021-02-25 16:43:32 -08:00
stripspace.c
stripspace: allow -s/-c outside git repository
2018-12-26 15:41:47 -08:00
submodule--helper.c
Merge branch 'tb/precompose-prefix-too'
2021-02-12 14:21:04 -08:00
symbolic-ref.c
symbolic-ref: don't leak shortened refname in check_symref()
2021-03-14 15:57:59 -07:00
tag.c
Merge branch 'js/params-vs-args'
2021-02-25 16:43:32 -08:00
unpack-file.c
…
unpack-objects.c
sha1-file: pass git_hash_algo to hash_object_file()
2020-01-31 10:45:39 -08:00
update-index.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
update-ref.c
update-ref: disallow "start" for ongoing transactions
2020-11-16 13:44:01 -08:00
update-server-info.c
…
upload-archive.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
upload-pack.c
builtin: consistently pass cmd_* prefix to parse_options
2019-05-13 14:22:53 +09:00
var.c
…
verify-commit.c
Merge branch 'jk/no-system-includes-in-dot-c'
2019-07-31 14:38:56 -07:00
verify-pack.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
verify-tag.c
verify-tag: drop signal.h include
2019-06-19 08:19:21 -07:00
worktree.c
worktree: fix leak in dwim_branch()
2021-03-14 15:57:59 -07:00
write-tree.c
cmd_{read,write}_tree: rename "unused" variable that is used
2019-05-13 14:22:53 +09:00