Patrick Steinhardt 8a7846383e midx-write: fix leaking hashfile on error cases
When writing the MIDX file we first create the `struct hashfile` used to
write the trailer hash, and then afterwards we verify whether we can
actually write the MIDX in the first place. When we decide that we
can't, this leads to a memory leak because we never free the hash file
contents.

We could fix this by freeing the hashfile on the exit path. There is a
better option though: we can simply move the checks for the error
condition earlier. As there is no early exit between creating the
hashfile and finalizing it anymore this is sufficient to fix the memory
leak.

While at it, also move around the block checking for `ctx.entries_nr`.
This change is not required to fix the memory leak, but it feels natural
to move together all massaging of parameters before we go with them and
execute the actual logic.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-08-22 09:18:04 -07:00
2024-08-19 11:07:38 -07:00
2024-05-24 11:40:44 -07:00
2024-08-16 12:51:51 -07:00
2023-11-26 10:07:06 +09:00
2024-05-27 11:20:00 -07:00
2024-07-08 14:53:10 -07:00
2024-07-02 09:59:00 -07:00
2024-06-17 15:55:55 -07:00
2024-08-09 08:47:34 -07:00
2024-07-08 14:53:10 -07:00
2023-12-26 12:04:32 -08:00
2024-07-08 14:53:10 -07:00
2024-07-08 14:53:11 -07:00
2024-06-14 10:26:33 -07:00
2024-06-14 10:26:33 -07:00
2024-01-23 10:40:10 -08:00
2024-06-14 10:26:33 -07:00
2024-07-08 14:53:10 -07:00
2024-07-08 14:53:10 -07:00
2024-06-04 15:07:08 -07:00
2024-06-14 10:26:33 -07:00
2024-04-05 15:21:14 -07:00
2024-07-08 14:53:10 -07:00
2024-08-14 10:08:01 -07:00
2024-06-14 10:26:33 -07:00
2024-06-14 10:26:33 -07:00
2024-08-09 08:47:34 -07:00
2024-08-08 09:36:53 -07:00
2023-04-17 21:15:56 +02:00
2023-11-26 10:07:05 +09:00
2024-08-16 12:52:53 -07:00
2024-08-14 10:07:56 -07:00
2023-11-26 10:07:05 +09:00
2023-06-28 14:06:39 -07:00
2024-06-14 10:26:33 -07:00
2024-08-09 08:47:34 -07:00
2024-08-02 08:30:08 -07:00
2023-06-28 14:06:39 -07:00
2024-04-19 12:38:50 +02:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2024-06-14 10:26:33 -07:00
2024-08-09 08:47:34 -07:00
2024-08-22 09:18:03 -07:00
2024-08-15 13:22:12 -07:00
2024-07-08 14:53:10 -07:00
2024-02-26 15:34:01 -08:00
2024-02-26 15:34:01 -08:00
2024-07-08 14:53:10 -07:00
2024-07-08 14:53:10 -07:00
2024-08-09 08:47:34 -07:00
2024-06-11 13:15:05 -07:00
2024-07-08 14:53:10 -07:00
2024-06-14 10:26:33 -07:00
2024-06-14 10:26:33 -07:00
2024-07-25 09:03:00 -07:00
2024-07-25 09:03:00 -07:00
2024-05-24 11:40:42 -07:00
2024-05-24 11:40:42 -07:00
2024-06-24 16:39:15 -07:00
2023-11-26 10:07:05 +09:00
2024-08-09 08:47:34 -07:00
2024-06-14 10:26:33 -07:00
2024-05-11 17:22:17 +02:00
2024-04-05 15:21:14 -07:00
2024-08-16 12:51:51 -07:00
2024-08-16 12:51:51 -07:00
2024-07-02 09:59:00 -07:00
2024-08-16 12:52:53 -07:00
2024-07-02 09:59:01 -07:00
2024-07-02 09:59:01 -07:00
2024-07-08 14:53:10 -07:00
2024-06-14 10:26:33 -07:00
2024-06-14 10:26:33 -07:00
2024-08-09 08:47:34 -07:00
2024-07-02 09:59:00 -07:00
2024-06-14 10:26:33 -07:00
2023-11-26 10:07:05 +09:00
2024-08-09 08:47:34 -07:00
2024-03-02 11:12:16 -08:00
2024-06-14 10:26:33 -07:00
2023-12-27 14:52:24 -08:00
2023-09-15 17:08:46 -07:00
2024-06-12 13:37:15 -07:00
2024-04-19 12:38:37 +02:00
2024-05-17 10:33:39 -07:00
2023-11-26 10:07:05 +09:00
2023-03-17 14:03:09 -07:00
2024-05-23 11:04:27 -07:00
2024-06-14 10:26:33 -07:00
2024-06-14 10:26:33 -07:00
2023-06-28 14:06:39 -07:00
2024-04-05 15:16:27 -07:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2024-08-09 08:47:34 -07:00
2023-04-04 14:28:27 -07:00
2024-08-09 08:47:34 -07:00
2024-06-24 16:39:15 -07:00
2023-05-17 10:11:41 -07:00
2024-06-14 10:26:33 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 582 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%