mirror of
https://github.com/git/git.git
synced 2026-01-11 13:23:12 +09:00
6c397d0104
The advice message currently suggests using "git config advice..." to disable advice messages, but since 00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06) we have the "set" subcommand for config. Since using the subcommand is more in-line with the modern interface, any advice should be promoting its usage. Change the disable advice message to use the subcommand instead. Change all uses of "git config advice" in the tests to use the subcommand. Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
103 lines
2.3 KiB
Bash
Executable File
103 lines
2.3 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='Test advise_if_enabled functionality'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=trunk
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'advice should be printed when config variable is unset' '
|
|
cat >expect <<-\EOF &&
|
|
hint: This is a piece of advice
|
|
hint: Disable this message with "git config set advice.nestedTag false"
|
|
EOF
|
|
test-tool advise "This is a piece of advice" 2>actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'advice should be printed when config variable is set to true' '
|
|
cat >expect <<-\EOF &&
|
|
hint: This is a piece of advice
|
|
EOF
|
|
test_config advice.nestedTag true &&
|
|
test-tool advise "This is a piece of advice" 2>actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'advice should not be printed when config variable is set to false' '
|
|
test_config advice.nestedTag false &&
|
|
test-tool advise "This is a piece of advice" 2>actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'advice should not be printed when --no-advice is used' '
|
|
q_to_tab >expect <<-\EOF &&
|
|
On branch trunk
|
|
|
|
No commits yet
|
|
|
|
Untracked files:
|
|
QREADME
|
|
|
|
nothing added to commit but untracked files present
|
|
EOF
|
|
|
|
test_when_finished "rm -fr advice-test" &&
|
|
git init advice-test &&
|
|
(
|
|
cd advice-test &&
|
|
>README &&
|
|
git --no-advice status
|
|
) >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'advice should not be printed when GIT_ADVICE is set to false' '
|
|
q_to_tab >expect <<-\EOF &&
|
|
On branch trunk
|
|
|
|
No commits yet
|
|
|
|
Untracked files:
|
|
QREADME
|
|
|
|
nothing added to commit but untracked files present
|
|
EOF
|
|
|
|
test_when_finished "rm -fr advice-test" &&
|
|
git init advice-test &&
|
|
(
|
|
cd advice-test &&
|
|
>README &&
|
|
GIT_ADVICE=false git status
|
|
) >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'advice should be printed when GIT_ADVICE is set to true' '
|
|
q_to_tab >expect <<-\EOF &&
|
|
On branch trunk
|
|
|
|
No commits yet
|
|
|
|
Untracked files:
|
|
(use "git add <file>..." to include in what will be committed)
|
|
QREADME
|
|
|
|
nothing added to commit but untracked files present (use "git add" to track)
|
|
EOF
|
|
|
|
test_when_finished "rm -fr advice-test" &&
|
|
git init advice-test &&
|
|
(
|
|
cd advice-test &&
|
|
>README &&
|
|
GIT_ADVICE=true git status
|
|
) >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|