Jeff King 2db6b83d18 shortlog: replace hand-parsing of author with pretty-printer ...

When gathering the author and oneline subject for each
commit, we hand-parse the commit headers to find the
"author" line, and then continue past to the blank line at
the end of the header.

We can replace this tricky hand-parsing by simply asking the
pretty-printer for the relevant items. This also decouples
the author and oneline parsing, opening up some new
optimizations in further commits.

One reason to avoid the pretty-printer is that it might be
less efficient than hand-parsing. However, I measured no
slowdown at all running "git shortlog -ns HEAD" on
linux.git.

As a bonus, we also fix a memory leak in the (uncommon) case
that the author field is blank.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2016-01-19 09:54:14 -08:00

..

add.c

Merge branch 'jc/add-u-A-default-to-top' into maint

2015-11-05 12:18:12 -08:00

am.c

Convert struct object to object_id

2015-11-20 08:02:05 -05:00

annotate.c

annotate: use argv_array

2014-07-16 11:10:11 -07:00

apply.c

apply: convert root string to strbuf

2015-10-05 11:08:04 -07:00

archive.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

bisect--helper.c

…

blame.c

Merge branch 'bc/object-id'

2015-12-10 12:36:13 -08:00

branch.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

bundle.c

bundle: verify arguments more strictly

2015-05-08 10:52:11 -07:00

cat-file.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

check-attr.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

check-ignore.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

check-mailmap.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

check-ref-format.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

checkout-index.c

prefix_path(): unconditionally free results in the callers

2015-05-05 10:31:51 -07:00

checkout.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

clean.c

use strbuf_complete to conditionally append slash

2015-10-05 11:08:06 -07:00

clone.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

column.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

commit-tree.c

Convert struct object to object_id

2015-11-20 08:02:05 -05:00

commit.c

Merge branch 'bc/object-id'

2015-12-10 12:36:13 -08:00

config.c

config: use xstrfmt in normalize_value

2015-09-25 10:18:18 -07:00

count-objects.c

prepare_packed_git(): refactor garbage reporting in pack directory

2015-08-17 09:14:59 -07:00

credential.c

…

describe.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

diff-files.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

diff-index.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

diff-tree.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

diff.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

fast-export.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

fetch-pack.c

add_sought_entry_mem: convert to struct object_id

2015-11-20 08:02:05 -05:00

fetch.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

fmt-merge-msg.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

for-each-ref.c

ref-filter: add option to match literal pattern

2015-09-17 10:02:49 -07:00

fsck.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

gc.c

Merge branch 'dk/gc-idx-wo-pack'

2015-11-20 06:55:34 -05:00

get-tar-commit-id.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

grep.c

Merge branch 'bc/object-id'

2015-12-10 12:36:13 -08:00

hash-object.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

help.c

convert strncpy to memcpy

2015-10-05 11:08:06 -07:00

index-pack.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

init-db.c

initdb: make safe_create_dir public

2015-11-20 04:52:01 -05:00

interpret-trailers.c

trailer: add interpret-trailers command

2014-10-13 13:55:27 -07:00

log.c

format-patch: add an option to suppress commit hash

2015-12-15 10:03:40 -08:00

ls-files.c

ps_matched: xcalloc() takes nmemb and then element size

2015-08-20 09:57:38 -07:00

ls-remote.c

Convert struct ref to use object_id.

2015-11-20 08:02:05 -05:00

ls-tree.c

convert trivial sprintf / strcpy calls to xsnprintf

2015-09-25 10:18:18 -07:00

mailinfo.c

mailinfo: libify

2015-10-21 15:59:34 -07:00

mailsplit.c

mailsplit: make PATH_MAX buffers dynamic

2015-09-25 10:18:18 -07:00

merge-base.c

Convert struct object to object_id

2015-11-20 08:02:05 -05:00

merge-file.c

Merge branch 'jk/merge-file-exit-code' into maint

2015-11-03 15:32:41 -08:00

merge-index.c

use sha1_to_hex_r() instead of strcpy

2015-10-05 11:08:05 -07:00

merge-ours.c

…

merge-recursive.c

convert trivial sprintf / strcpy calls to xsnprintf

2015-09-25 10:18:18 -07:00

merge-tree.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

merge.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

mktag.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

mktree.c

builtin/mktree.c: use ALLOC_GROW() in append_to_tree()

2014-03-03 14:54:45 -08:00

mv.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

name-rev.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

notes.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

pack-objects.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

pack-redundant.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

pack-refs.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

patch-id.c

usage: do not insist that standard input must come from a file

2015-10-16 15:27:52 -07:00

prune-packed.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

prune.c

Merge branch 'jk/repository-extension' into maint

2015-11-03 15:32:25 -08:00

pull.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

push.c

push: don't mark options of recurse-submodules for translation

2015-12-22 14:40:47 -08:00

read-tree.c

convert trivial sprintf / strcpy calls to xsnprintf

2015-09-25 10:18:18 -07:00

receive-pack.c

Convert struct ref to use object_id.

2015-11-20 08:02:05 -05:00

reflog.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

remote-ext.c

remote-ext: simplify git pkt-line generation

2015-09-25 10:18:18 -07:00

remote-fd.c

…

remote.c

ref_newer: convert to use struct object_id

2015-11-20 08:02:05 -05:00

repack.c

Merge branch 'jk/repository-extension' into maint

2015-11-03 15:32:25 -08:00

replace.c

Convert struct object to object_id

2015-11-20 08:02:05 -05:00

rerere.c

Sync with 2.6.1

2015-10-05 13:20:08 -07:00

reset.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

rev-list.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

rev-parse.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

revert.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

rm.c

use file_exists() to check if a file exists in the worktree

2015-05-20 13:49:10 -07:00

send-pack.c

push: add a config option push.gpgSign for default signed pushes

2015-08-19 12:58:58 -07:00

shortlog.c

shortlog: replace hand-parsing of author with pretty-printer

2016-01-19 09:54:14 -08:00

show-branch.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

show-ref.c

show-ref: stop using PARSE_OPT_NO_INTERNAL_HELP

2015-11-20 08:02:07 -05:00

stripspace.c

Merge branch 'jc/usage-stdin' into maint

2015-11-03 15:32:38 -08:00

submodule--helper.c

submodule: rewrite module_clone shell function in C

2015-09-08 15:48:21 -07:00

symbolic-ref.c

symbolic-ref: propagate error code from create_symref()

2015-12-21 12:03:03 -08:00

tag.c

Merge branch 'kn/for-each-tag'

2015-10-26 15:55:22 -07:00

unpack-file.c

convert trivial sprintf / strcpy calls to xsnprintf

2015-09-25 10:18:18 -07:00

unpack-objects.c

Remove get_object_hash.

2015-11-20 08:02:05 -05:00

update-index.c

Merge branch 'nd/untracked-cache'

2015-05-26 13:24:46 -07:00

update-ref.c

tag, update-ref: improve description of option "create-reflog"

2015-09-11 09:50:02 -07:00

update-server-info.c

…

upload-archive.c

upload-archive: convert sprintf to strbuf

2015-09-25 10:18:18 -07:00

var.c

…

verify-commit.c

verify-commit: add option to print raw gpg status information

2015-06-22 14:20:47 -07:00

verify-pack.c

standardize usage info string format

2015-01-14 09:32:04 -08:00

verify-tag.c

verify-tag: add option to print raw gpg status information

2015-06-22 14:20:47 -07:00

worktree.c

Convert struct object to object_id

2015-11-20 08:02:05 -05:00

write-tree.c

…