Taylor Blau
2a15964128
builtin/repack.c: be more conservative with unsigned overflows ...
There are a number of places in the geometric repack code where we
multiply the number of objects in a pack by another unsigned value. We
trust that the number of objects in a pack is always representable by a
uint32_t, but we don't necessarily trust that that number can be
multiplied without overflow.
Sprinkle some unsigned_add_overflows() and unsigned_mult_overflows() in
split_pack_geometry() to check that we never overflow any unsigned types
when adding or multiplying them.
Arguably these checks are a little too conservative, and certainly they
do not help the readability of this function. But they are serving a
useful purpose, so I think they are worthwhile overall.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-03-05 11:33:52 -08:00
2020-09-30 12:53:47 -07:00
2021-01-06 15:10:49 -08:00
2020-07-30 19:18:06 -07:00
2018-08-13 14:14:44 -07:00
2019-01-02 13:05:30 -08:00
2021-02-03 14:52:09 -08:00
2021-01-25 14:19:19 -08:00
2021-02-05 16:40:45 -08:00
2020-12-01 13:05:37 -08:00
2020-08-11 18:04:11 -07:00
2020-07-09 14:00:41 -07:00
2019-01-24 11:55:06 -08:00
2020-08-18 17:17:31 -07:00
2021-01-12 14:04:42 -08:00
2020-10-27 12:41:56 -07:00
2021-01-23 17:14:07 -08:00
2020-09-10 10:49:19 -07:00
2021-02-17 17:21:40 -08:00
2019-05-13 14:22:53 +09:00
2021-01-06 15:10:49 -08:00
2020-04-28 10:47:10 -07:00
2021-01-12 14:04:42 -08:00
2020-11-25 14:43:48 -08:00
2018-11-13 14:22:02 +09:00
2020-08-13 11:02:08 -07:00
2020-09-03 12:37:03 -07:00
2020-11-25 12:30:18 -08:00
2020-10-16 12:30:45 -07:00
2021-01-21 15:51:31 -08:00
2021-02-12 14:21:04 -08:00
2021-02-03 14:09:37 -08:00
2021-02-03 14:09:37 -08:00
2021-02-12 14:21:04 -08:00
2020-11-11 12:55:27 -08:00
2020-09-30 12:53:47 -07:00
2021-01-06 15:10:49 -08:00
2020-11-02 13:17:40 -08:00
2021-02-05 13:49:54 -08:00
2021-02-17 17:21:40 -08:00
2020-03-24 15:04:43 -07:00
2021-01-07 15:13:21 -08:00
2021-01-07 19:12:02 -08:00
2021-01-05 14:58:29 -08:00
2021-02-09 23:09:29 -08:00
2019-04-01 11:57:39 +09:00
2021-02-17 17:21:41 -08:00
2019-05-13 14:22:53 +09:00
2020-08-04 18:34:01 -07:00
2021-01-25 18:32:44 -08:00
2020-12-13 15:53:50 -08:00
2020-04-28 10:47:10 -07:00
2021-02-17 17:21:41 -08:00
2021-01-23 11:48:20 -08:00
2021-02-05 13:49:54 -08:00
2019-01-14 15:29:28 -08:00
2020-02-11 09:59:39 -08:00
2018-11-06 12:56:29 +09:00
2019-01-24 11:55:06 -08:00
2019-01-24 11:55:06 -08:00
2019-08-19 10:08:03 -07:00
2020-10-20 12:53:26 -07:00
2021-02-05 16:40:44 -08:00
2021-01-06 14:22:24 -08:00
2019-05-13 14:22:54 +09:00
2019-10-23 12:05:06 +09:00
2020-07-20 14:35:43 -07:00
2021-01-28 12:03:26 -08:00
2020-04-28 10:47:10 -07:00
2021-02-22 23:30:52 -08:00
2021-01-25 14:19:18 -08:00
2019-04-26 10:54:03 +09:00
2019-12-09 12:26:40 -08:00
2020-03-24 15:04:44 -07:00
2020-05-13 12:19:18 -07:00
2020-12-15 17:39:42 -08:00
2020-10-27 15:09:49 -07:00
2021-02-17 17:21:41 -08:00
2020-04-28 10:47:10 -07:00
2021-02-05 16:31:22 -08:00
2020-12-08 15:11:20 -08:00
2021-02-11 09:21:52 -08:00
2020-07-28 15:02:18 -07:00
2020-11-25 14:43:47 -08:00
2021-03-05 11:33:52 -08:00
2020-07-30 19:18:06 -07:00
2019-01-15 15:38:29 -08:00
2020-09-02 14:39:25 -07:00
2020-08-07 15:13:03 -07:00
2020-12-12 23:35:51 -08:00
2020-11-18 13:32:53 -08:00
2020-02-19 10:56:49 -08:00
2020-10-03 09:59:19 -07:00
2021-01-25 14:19:19 -08:00
2020-09-09 13:53:09 -07:00
2020-05-27 10:07:07 -07:00
2021-01-21 15:51:31 -08:00
2021-01-23 17:14:07 -08:00
2021-02-05 16:31:22 -08:00
2018-12-26 15:41:47 -08:00
2021-02-12 14:21:04 -08:00
2021-02-05 16:40:45 -08:00
2018-05-16 11:42:03 +09:00
2020-01-31 10:45:39 -08:00
2020-04-28 10:47:10 -07:00
2020-11-16 13:44:01 -08:00
2018-02-09 10:24:50 -08:00
2020-07-30 19:18:06 -07:00
2019-05-13 14:22:53 +09:00
2019-07-31 14:38:56 -07:00
2020-08-11 18:04:11 -07:00
2019-06-19 08:19:21 -07:00
2021-01-30 09:57:40 -08:00
2019-05-13 14:22:53 +09:00
2a15964128