Taylor Blau 16749b8dd2 commit-graph.c: handle commit parsing errors
To write a commit graph chunk, 'write_graph_chunk_data()' takes a list
of commits to write and parses each one before writing the necessary
data, and continuing on to the next commit in the list.

Since the majority of these commits are not parsed ahead of time (an
exception is made for the *last* commit in the list, which is parsed
early within 'copy_oids_to_commits'), it is possible that calling
'parse_commit_no_graph()' on them may return an error. Failing to catch
these errors before de-referencing later calls can result in a undefined
memory access and a SIGSEGV.

One such example of this is 'get_commit_tree_oid()', which expects a
parsed object as its input (in this case, the commit-graph code passes
'*list'). If '*list' causes a parse error, the subsequent call will
fail.

Prevent such an issue by checking the return value of
'parse_commit_no_graph()' to avoid passing an unparsed object to a
function which expects a parsed object, thus preventing a segfault.

It is worth noting that this fix is really skirting around the issue in
object.c's 'parse_object()', which makes it difficult to tell how
corrupt an object is without digging into it. Presumably one could
change the meaning of 'parse_object' returns, but this would require
adjusting each callsite accordingly. Instead of that, add an additional
check to the object parsed.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-09-09 10:55:58 -07:00
2019-07-29 12:39:13 -07:00
2019-08-22 12:34:11 -07:00
2019-08-02 13:12:02 -07:00
2019-08-22 12:41:04 -07:00
2019-04-01 11:57:39 +09:00
2019-04-01 11:57:39 +09:00
2019-05-14 16:45:01 +09:00
2019-05-30 10:50:45 -07:00
2019-08-02 13:12:02 -07:00
2018-09-12 15:15:34 -07:00
2019-01-02 10:19:05 -08:00
2019-07-19 11:30:21 -07:00
2019-07-19 11:30:20 -07:00
2019-07-09 15:25:44 -07:00
2019-07-09 15:25:44 -07:00
2019-07-25 13:59:20 -07:00
2018-03-30 12:49:57 -07:00
2018-03-30 12:49:57 -07:00
2018-08-20 12:41:32 -07:00
2019-07-09 15:25:43 -07:00
2019-05-05 15:20:10 +09:00
2018-10-19 13:34:02 +09:00
2019-07-09 15:25:43 -07:00
2019-05-13 23:50:32 +09:00
2019-07-19 11:30:20 -07:00
2019-07-25 13:59:20 -07:00
2019-08-22 12:41:04 -07:00
2019-08-02 13:12:02 -07:00
2019-06-13 13:19:42 -07:00
2019-05-05 15:20:10 +09:00
2019-04-22 11:14:43 +09:00
2017-09-06 17:19:54 +09:00
2018-08-29 13:05:35 -07:00
2019-08-02 13:12:02 -07:00
2019-01-14 12:13:04 -08:00
2019-06-11 10:34:40 -07:00
2019-07-09 15:25:43 -07:00
2019-07-19 11:30:19 -07:00
2019-07-19 11:30:20 -07:00
2019-07-19 11:30:20 -07:00
2019-05-05 15:20:10 +09:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2019-06-17 18:15:04 -07:00
2019-02-05 14:26:09 -08:00
2018-11-02 12:14:21 +09:00
2019-07-11 15:16:49 -07:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2018-08-15 15:08:23 -07:00
2019-04-01 11:57:39 +09:00
2019-08-22 12:41:04 -07:00
2019-01-14 12:13:04 -08:00
2019-05-05 15:20:10 +09:00
2018-06-01 15:06:37 +09:00
2019-02-05 14:26:11 -08:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2019-05-13 23:50:35 +09:00
2019-05-05 15:20:10 +09:00
2019-06-21 11:24:08 -07:00
2018-10-19 13:34:02 +09:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 582 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%