Jeff King 143588949c fetch: ignore SIGPIPE during network operation
The default SIGPIPE behavior can be useful for a command that generates
a lot of output: if the receiver of our output goes away, we'll be
notified asynchronously to stop generating it (typically by killing the
program).

But for a command like fetch, which is primarily concerned with
receiving data and writing it to disk, an unexpected SIGPIPE can be
awkward. We're already checking the return value of all of our write()
calls, and dying due to the signal takes away our chance to gracefully
handle the error.

On Linux, we wouldn't generally see SIGPIPE at all during fetch. If the
other side of the network connection hangs up, we'll see ECONNRESET. But
on OS X, we get a SIGPIPE, and the process is killed. This causes t5570
to racily fail, as we sometimes die by signal (instead of the expected
die() call) when the server side hangs up.

Let's ignore SIGPIPE during the network portion of the fetch, which will
cause our write() to return EPIPE, giving us consistent behavior across
platforms.

This fixes the test flakiness, but note that it stops short of fixing
the larger problem. The server side hit a fatal error, sent us an "ERR"
packet, and then hung up. We notice the failure because we're trying to
write to a closed socket. But by dying immediately, we never actually
read the ERR packet and report its content to the user. This is a (racy)
problem on all platforms. So this patch lays the groundwork from which
that problem might be fixed consistently, but it doesn't actually fix
it.

Note the placement of the SIGPIPE handling. The absolute minimal change
would be to ignore SIGPIPE only when we're writing. But twiddling the
signal handler for each write call is inefficient and maintenance
burden. On the opposite end of the spectrum, we could simply declare
that fetch does not need SIGPIPE handling, since it doesn't generate a
lot of output, and we could just ignore it at the start of cmd_fetch().

This patch takes a middle ground. It ignores SIGPIPE during the network
operation (which is admittedly most of the program, since the actual
network operations are all done under the hood by the transport code).
So it's still pretty coarse.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-03-05 15:02:18 +09:00
2018-12-01 21:41:45 +09:00
2018-12-15 12:31:34 +09:00
2018-12-07 19:43:07 +01:00
2018-08-02 13:54:58 -07:00
2018-11-02 11:04:53 +09:00
2018-08-20 12:41:32 -07:00
2018-11-05 13:42:11 +09:00
2018-09-12 15:15:34 -07:00
2018-07-26 10:12:51 -07:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2018-11-02 11:04:53 +09:00
2017-05-02 10:46:41 +09:00
2018-03-30 12:49:57 -07:00
2018-03-30 12:49:57 -07:00
2018-05-08 15:59:17 +09:00
2018-11-19 16:24:41 +09:00
2018-08-29 11:32:49 -07:00
2018-08-20 12:41:32 -07:00
2017-12-08 09:16:27 -08:00
2017-12-08 09:16:27 -08:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2018-11-13 22:37:20 +09:00
2018-05-08 15:59:17 +09:00
2018-10-30 15:43:48 +09:00
2018-12-15 12:31:34 +09:00
2018-11-02 11:04:53 +09:00
2018-11-05 13:42:11 +09:00
2018-11-05 13:42:11 +09:00
2018-12-12 17:18:29 +09:00
2018-07-16 14:27:39 -07:00
2018-11-29 15:45:31 +09:00
2018-05-30 21:51:28 +09:00
2018-10-30 15:43:39 +09:00
2017-09-06 17:19:54 +09:00
2018-10-19 13:34:02 +09:00
2018-08-29 13:05:35 -07:00
2018-11-29 15:45:31 +09:00
2018-11-13 22:37:19 +09:00
2018-10-19 13:34:02 +09:00
2018-08-29 11:32:49 -07:00
2018-08-20 15:31:40 -07:00
2018-08-29 11:32:49 -07:00
2018-10-04 11:12:14 -07:00
2018-10-04 11:12:14 -07:00
2018-11-21 20:39:02 +09:00
2018-02-02 11:28:41 -08:00
2018-06-01 15:06:37 +09:00
2018-10-19 13:34:02 +09:00
2019-03-05 15:02:01 +09:00
2018-11-18 18:23:52 +09:00
2018-11-02 12:14:21 +09:00
2018-11-02 12:14:21 +09:00
2017-12-19 11:33:55 -08:00
2018-01-16 12:16:54 -08:00
2018-08-15 15:08:23 -07:00
2018-12-15 12:31:34 +09:00
2018-09-17 13:53:52 -07:00
2018-03-15 12:01:08 -07:00
2018-08-20 15:31:40 -07:00
2018-09-17 13:53:57 -07:00
2018-06-01 15:06:37 +09:00
2018-11-02 11:04:54 +09:00
2018-11-02 11:04:54 +09:00
2018-11-29 16:28:39 +09:00
2018-10-19 13:34:02 +09:00
2018-08-15 11:52:09 -07:00
2018-05-30 21:51:28 +09:00
2018-10-19 13:34:02 +09:00
2018-08-15 15:08:25 -07:00
2018-08-20 12:41:32 -07:00
2018-07-18 12:20:28 -07:00
2018-10-19 13:34:02 +09:00

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 582 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%