From bc8556d06652c50bb0ab03dd75fe31a1909975a4 Mon Sep 17 00:00:00 2001 From: Tian Yuchen Date: Sat, 17 Jan 2026 14:25:15 +0800 Subject: [PATCH] t1005: modernize "! test -f" to "test_path_is_missing" Replace instances of "! test -f " with "test_path_is_missing ". This macro provides better diagnostics when the test fails (it prints "Path exists:" instead of silently failing). Signed-off-by: Tian Yuchen Signed-off-by: Junio C Hamano --- t/t1005-read-tree-reset.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/t1005-read-tree-reset.sh b/t/t1005-read-tree-reset.sh index 6b5033d0ce..1bf384dd0f 100755 --- a/t/t1005-read-tree-reset.sh +++ b/t/t1005-read-tree-reset.sh @@ -40,7 +40,7 @@ test_expect_success 'reset should remove remnants from a failed merge' ' git ls-files -s && read_tree_u_must_succeed --reset -u HEAD && git ls-files -s >actual && - ! test -f old && + test_path_is_missing old && test_cmp expect actual ' @@ -56,7 +56,7 @@ test_expect_success 'two-way reset should remove remnants too' ' git ls-files -s && read_tree_u_must_succeed --reset -u HEAD HEAD && git ls-files -s >actual && - ! test -f old && + test_path_is_missing old && test_cmp expect actual ' @@ -72,7 +72,7 @@ test_expect_success 'Porcelain reset should remove remnants too' ' git ls-files -s && git reset --hard && git ls-files -s >actual && - ! test -f old && + test_path_is_missing old && test_cmp expect actual ' @@ -88,7 +88,7 @@ test_expect_success 'Porcelain checkout -f should remove remnants too' ' git ls-files -s && git checkout -f && git ls-files -s >actual && - ! test -f old && + test_path_is_missing old && test_cmp expect actual ' @@ -104,7 +104,7 @@ test_expect_success 'Porcelain checkout -f HEAD should remove remnants too' ' git ls-files -s && git checkout -f HEAD && git ls-files -s >actual && - ! test -f old && + test_path_is_missing old && test_cmp expect actual '