eyecatchu/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-11 13:23:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

refs/files: remove useless indirection

Browse Source 
The function `files_fsck_refs()` only has a single callsite and forwards
all of its arguments as-is, so it's basically a useless indirection.
Inline the function call.

While at it, also remove the bitwise or that we have for return values.
We don't really want to or them at all, but rather just want to return
an error in case either of the functions has failed.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2026-01-09 13:39:33 +01:00 committed by Junio C Hamano
parent 9262da11b5
commit 328de3c71e
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
refs/files-backend.c
View File

@ -3954,22 +3954,20 @@ out:
return ret;
}
static int files_fsck_refs(struct ref_store *ref_store,
struct fsck_options *o,
struct worktree *wt)
{
return files_fsck_refs_dir(ref_store, o, wt);
}
static int files_fsck(struct ref_store *ref_store,
struct fsck_options *o,
struct worktree *wt)
{
struct files_ref_store *refs =
files_downcast(ref_store, REF_STORE_READ, "fsck");
int ret = 0;
return files_fsck_refs(ref_store, o, wt) |
refs->packed_ref_store->be->fsck(refs->packed_ref_store, o, wt);
if (files_fsck_refs_dir(ref_store, o, wt) < 0)
ret = -1;
if (refs->packed_ref_store->be->fsck(refs->packed_ref_store, o, wt) < 0)
ret = -1;
return ret;
}
struct ref_storage_be refs_be_files = {